Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small changes to extrapolation #123

Merged
merged 3 commits into from
Oct 30, 2024
Merged

small changes to extrapolation #123

merged 3 commits into from
Oct 30, 2024

Conversation

lennybronner
Copy link
Collaborator

@lennybronner lennybronner commented Oct 30, 2024 •
edited
Loading

Description

I accidentally merged the earlier PR. This makes sure that the versioned dates work when we pass in strings, and also that logging works properly.

Jira Ticket

Test Steps

@lennybronner lennybronner requested a review from a team as a code owner October 30, 2024 03:09
jjcherian
jjcherian approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jjcherian jjcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lennybronner lennybronner merged commit 102cc7c into develop Oct 30, 2024
3 checks passed
@lennybronner lennybronner deleted the extrapolation-rule branch October 30, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjcherian jjcherian jjcherian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lennybronner @jjcherian