Sort KEYWORDS for consistent output ordering #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure either how to best test this feature. And actually currently no test validate the content of the KEYWORDS and SOFT_KEYWORDS attributes. So you could add a test under test_pegen.py generating a parser from a small grammar containing both hard and soft keywords and testing that the output is as expected. The other tests there should illustrate how to easily generate the parser class. Let me know if you need further guidance. |
|
Thanks for the guidance! I've added a test that seems to do the job. |
lysnikolaou
approved these changes
Sep 29, 2021
|
Thanks, @edemaine! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40 by adding
sorted(...)as suggested previously.I could use some guidance for writing tests.