Fix missing legends in PromGraph #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'legendFormat' has moved from the 2nd to 3rd positional parameter, so just name all the parameters to avoid hitting this again.
bboreham
force-pushed
the
fix-promgraph-legend
branch
from
152aa17 to
d3f1b11
Compare
bboreham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bug whereby all legends are missing from
PromGraphpanels.The bug was caused by
legendFormatmoving from the 2nd to 3rd positional parameter ofGraph.So I just named all the parameters to avoid hitting this again.