Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Driver Service Fix Update #196

Merged
merged 35 commits into from
Sep 30, 2023
Merged

Driver Service Fix Update #196

merged 35 commits into from
Sep 30, 2023

Conversation

goosewobbler
Copy link
Member

@goosewobbler goosewobbler commented Sep 29, 2023 •
edited
Loading

  • Replaced appPath / appName / binaryPath with appBinaryPath to reduce complexity
  • Exposed getBinaryPath helper from wdio-electron-service/utils to assist users of appPath / appName
  • Separate launcher tests
  • Reverted CI script to previous state for release
  • Restructured examples directories
  • ESM example app is now ESM - using Electron 28 (currently nightly)
  • Now using Rollup instead of Webpack for examples
  • CJS build now using symlinks instead of files with a single require()
  • Updated deps

@goosewobbler
extract from utils
51c740d
@goosewobbler
use appBinaryPath
811b1c4
@goosewobbler
formatting fix
915439a
@goosewobbler
add types for main & preload
c5d37c9
@goosewobbler
move getBinaryPath to utils, expose
03c419c
@goosewobbler
update deps
0c1c48d
@goosewobbler
fix merge
d3646b2
@goosewobbler
fix log import
433a2f8
@goosewobbler
log error
d776f56
@goosewobbler
duplicate getBinaryPath to fix build
d14be60
@goosewobbler
update lock
6c1fbde
@goosewobbler
update getBinaryPath
278c698
@goosewobbler
update for appBinaryPath
574d358
@goosewobbler
fix linting
78124ed
@goosewobbler
fix formatting
d87b70d
@goosewobbler
revert ci script
52833f6
@goosewobbler
rework examples
1e9a1c1
@goosewobbler
use rollup
5c12116
@goosewobbler
fix imports
c689cc9
@goosewobbler
update outdir
0ef3468
@goosewobbler
use symlinks pt.1
3d4072b
@goosewobbler
use symlinks pt.2
bd14dd3
@goosewobbler
revert to import
a9134b0
@goosewobbler
fix utils typing
0cbb239
@goosewobbler
update linting config
a7291cc
@goosewobbler
update lockfile
8eabd93
@goosewobbler
use unknown
44fe067
@goosewobbler
update lockfiles
d3fb192
@goosewobbler
extract nested ternary
dbe2d8b
@goosewobbler
add rule for ternaries, switch to standard filename for flat config
06a174f
christian-bromann
christian-bromann approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goosewobbler goosewobbler merged commit 96de4f8 into driver-service-fix Sep 30, 2023
@goosewobbler goosewobbler deleted the driver-service-fix-3 branch September 30, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-bromann christian-bromann christian-bromann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goosewobbler @christian-bromann