You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After looking for the CLA in docs for my first contribution found out the only reference to it had a link that didn't work (domain doesn't exist). Fixing that link + adding a link in PR template so impatient contributors like me can browse the CLA whilst the CLA signing comment appears.
Unfortunately it is still failing CI. I think that because it is modifying an .md file the linter step (to be more specific markdown-link-validator) is failing. I need to take a closer look to the markdown-link-validator usage to fix this and I'll ping you again 😅
Unfortunately it is still failing CI. I think that because it is modifying an .md file the linter step (to be more specific markdown-link-validator) is failing. I need to take a closer look to the markdown-link-validator usage to fix this and I'll ping you again 😅
Yup, no problem at all! I'll take a look too if have some time to help a bit moar :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
After looking for the CLA in docs for my first contribution found out the only reference to it had a link that didn't work (domain doesn't exist). Fixing that link + adding a link in PR template so impatient contributors like me can browse the CLA whilst the CLA signing comment appears.