Fixes #427, #556 use correct sourceType when parsing bundles

[eamodio]

Refs #427, #556

We are now parsing bundles as ES modules based on stats JSON information

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: eamodio / name: Eric Amodio (a0199c2)
• ✅ login: valscion / name: Vesa Laakso (0d6e706)

[evenstensberg]

Sign the CLA please 🥰

[eamodio]

Done 😀

[valscion]

Thanks! I wonder if there is any other solution than forcing the user to change an option? Is there some way we could infer whethet the source content is a module and not a script?

I'd rather avoid adding more options to support something which should work out-of-the-box.

[eamodio]

Agreed, but not sure how to detect that. Ideas?

[alexander-akait]

Each asset has javascriptModule: true in info when it is a ECMA module, so it can be infer from it (https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/src/index.js#L490), I don't think using global parserOptions is good idea, because technically webpack can generates and ECMA modules and any other module system

[valscion]

Each assets has javascriptModule: true in info when it is a ECMA module, so it can be infer from it (https://github.com/webpack-contrib/terser-webpack-plugin/blob/master/src/index.js#L490), I don't think using global parserOptions is good idea, because technically webpack can generates and ECMA modules and any other module system

Oh that's nice! So the information coming from stats JSON should definitely be used here over a global option.

The first change could be to only change the sourceType and leave other stuff alone if it makes sense.

[alexander-akait]

@eamodio Do you want to finish it, thank you?

[eamodio]

Updated

[valscion]

Thanks! I think this direction looks safe and seems to be backwards-compatible.

Can you modify the PR title, description and README.md to describe what has now changed?

For example, something like this:

"Parse bundles as ES modules based on stats JSON information"

[eamodio]

@valscion Updated the title & description, but not sure what you wanted added to the README as there isn't any new options or anything. But feel free to edit this PR as you see fit.

[valscion]

Ah sorry, I meant the changelog! My bad.

[eamodio]

Updated -- hopefully this is ready now

[valscion]

Can you avoid changing the formatting on all rows in the changelog? The diff there should be minimal.

Thank you for your patience with this PR. I'm mostly reviewing this on my phone so I can't easily modify the changes myself.

[eamodio]

Ugh, sorry, damn auto-formatter. Fixed

[valscion]

Looks great, thank you! ☺️