Fail crawl with fatal message if custom behavior isn't loaded #799
Conversation
| const newBehaviors = await collectLocalPathBehaviors(filePath, depth + 1); | ||
| behaviors.push(...newBehaviors); | ||
| } | ||
| if (!behaviors && depth === 0) { |
There was a problem hiding this comment.
Hm, does this mean that specifying an empty directory will lead to an error? I think that could be allowed, as long as directory exists?
There was a problem hiding this comment.
It will only lead to an error if pointed to a directory with no behaviors in that directory or any of its subdirectories. I think that makes sense? If someone is pointing at a directory or Git repo expecting the therein to get added but no behaviors are found, it's probably an error of some sort.
There was a problem hiding this comment.
(Pointing out Git repo here because we first clone the git repo and then collect behaviors from the cloned repo via this codepath)
There was a problem hiding this comment.
Yeah, just thinking if maybe should allow having a placeholder directory that things will be added to later.. I guess could always add a sample behavior or something like that..
There was a problem hiding this comment.
Yeah if we go that way I'd suggest we do add a sample behavior. Otherwise we might be setting people up for silent errors?
There was a problem hiding this comment.
I'll leave it up to your judgment though
Fixes #797
The crawler will now exit with a fatal log message and exit code 17 if:
--customBehaviorcannot be cloned successfully (new)--customBehavioris not fetched successfully (new)--customBehavior, or if an error is thrown while attempting to collect files from a nonexistent path (new)Browser.checkScriptvalidation (existing behavior)Tests have also been added accordingly.