Add new WIP QA Review page #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-qa-page
branch
from
2c47ccc to
524934e
Compare
|
Oh shoot that formatted everything, hold on |
emma-sg
force-pushed
the
frontend-qa-page
branch
from
11d4ed1 to
3d41efc
Compare
3 tasks
emma-sg
added a commit
that referenced
this pull request
Jan 31, 2024
Makes sure code quality stays high by checking that code is linted & formatted in CI. ### Reason Frustration — so that [things like this](#1500 (comment)) don't happen in the future. I tried to merge `main` into a branch to get it up to date with main, and main isn't totally formatted or linted properly, and then formatting the codebase introduced a whole bunch of unrelated changes. Running a formatter or linter shouldn't cause unrelated code changes, and `main` should always be in a correct state in terms of linting and formatting. ### Testing - [x] Test run with failing lint checks errors: https://github.com/webrecorder/browsertrix-cloud/actions/runs/7733354321/job/21085236200 - [x] Test run with failing formatting check errors: https://github.com/webrecorder/browsertrix-cloud/actions/runs/7733501666/job/21085717519 - [x] Test run with both passing lint & formatting checks passes: https://github.com/webrecorder/browsertrix-cloud/actions/runs/7733529142/job/21085796727
emma-sg
force-pushed
the
frontend-qa-page
branch
from
3d41efc to
03fbb52
Compare
Partially addresses #1503 <!-- Fixes #issue_number --> ### Changes - Adds a navigation button component, intended for use with tab-like interfaces - Converts the button and badge components to Tailwind - Also adds a `high-contrast` style variant to badges - Adds `prettier-plugin-tailwindcss` and updates `prettier` and `tailwindcss`, and adds a `tw` no-op function, which allows `prettier-plugin-tailwindcss` to sort Tailwind classes - I'll follow this up with a PR that applies the updated prettier defaults to everything ### Manual testing 1. Tested by hand with a scrap testing page ### Screenshots <img width="631" alt="Screenshot 2024-01-31 at 4 41 15 PM" src="https://github.com/webrecorder/browsertrix-cloud/assets/5727389/a7a3898c-4298-443c-b1c5-5062e634d226"> <!-- ### Follow-ups -->
tw4l
pushed a commit
that referenced
this pull request
Feb 22, 2024
Resolves #1493 <!-- Fixes #issue_number --> ### Changes Adds WIP QA page with basic grid layout sections and navigation. ### Manual testing Page can be access by adding `/review/screenshots` or `/review/replay` to a crawl detail page URL. For example: ``` /orgs/suas-dev-sandbox-2/items/crawl/manual-20240124023524-422e41d6-97d/review/screenshots ``` --------- Co-authored-by: emma <hi@emma.cafe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1493
Changes
Adds WIP QA page with basic grid layout sections and navigation.
Manual testing
Page can be access by adding
/review/screenshotsor/review/replayto a crawl detail page URL. For example:Screenshots