Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crawl errors incrementally during crawl #1561

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Feb 28, 2024

Fixes #1558

  • Adds crawl errors to database incrementally during crawl rather than after crawl completes
  • Simplifies crawl /errors API endpoint to always return errors from database

I've manually tested that errors are getting picked up and exposed by the API while crawl is running in local Browsertrix deployment.

@tw4l tw4l requested a review from ikreymer February 28, 2024 20:56
@tw4l tw4l force-pushed the issue-1558-crawl-errors branch from 4f7f473 to 0115705 Compare February 28, 2024 20:58
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, A nice simplification to the infrastructure - for once we're removing complexity instead of adding :)

@ikreymer ikreymer merged commit da19691 into main Feb 29, 2024
4 checks passed
@ikreymer ikreymer deleted the issue-1558-crawl-errors branch February 29, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add crawl errors to database incrementally during crawl
2 participants