Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator state fixes (follow up fomr #1639) #1640

Merged
merged 2 commits into from
Mar 29, 2024
Merged

operator state fixes (follow up fomr #1639) #1640

merged 2 commits into from
Mar 29, 2024

Conversation

ikreymer
Copy link
Member

  • increase time for going to waiting_capacity from starting to 150 seconds
  • relax requirement for state transitions, allow complete from waiting
  • additional type safety for different states, ensure mark_finished() only called with non-running states, add Literal types for all the state types.

@ikreymer
follow up to #1639 into main:
34ba49b 
- increase time for going to waiting_capacity from starting to 150 seconds
- relax requirement for state transitions, allow complete from waiting
- additional type checking for different states, ensure mark_finished() only called
with non-running states, etc...
@ikreymer ikreymer requested a review from tw4l March 29, 2024 21:32
tw4l
tw4l approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@ikreymer ikreymer merged commit ffc4b5b into main Mar 29, 2024
4 checks passed
@ikreymer ikreymer deleted the state-fixes branch March 29, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @tw4l