Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renumber crawl priority classes: #1673

Merged
merged 1 commit into from
Apr 13, 2024
Merged

renumber crawl priority classes: #1673

merged 1 commit into from
Apr 13, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Apr 12, 2024

  • priority classes <-10 are ignored by cluster-autoscaler so QA jobs with too low priorities never run
  • start crawl priorities at 0 going down (same as before)
  • start qa run priorities at -2 going down (instead of -100)
  • this means a crawl of with scale of 3 can be preempted by 1st qa pod, but otherwise crawls have higher priority
  • rename priority classes as they are otherwise immutable and error on helm upgrade

This allows for more room in lower pri classes for other type of objects, while keeping in mind the -10 and below threshold: (see: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md)

- priority classes <-10 are ignored by cluster-autoscaler so QA jobs with too low priorities never run
- keep crawl priorities at 0 going down
- start qa run priorities at -2 going down (instead of -100)
- this means a crawl of with scale of 3 can be preempted by 1st qa pod, but otherwise crawls have higher priority
@ikreymer ikreymer force-pushed the renumber-pri-classes branch from 9d9e0c9 to ad92a1f Compare April 13, 2024 18:09
@ikreymer ikreymer merged commit 95f5605 into main Apr 13, 2024
4 checks passed
@ikreymer ikreymer deleted the renumber-pri-classes branch April 13, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant