Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QA run aggregate stats API endpoint #1682

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Apr 16, 2024

Fixes #1659

Takes an arbitrary set of thresholds for text and screenshot matches as a comma-separated list of floats.

Returns a list of groupings for each that include the lower boundary and count for all sets that have matching data. Would be good if @ikreymer @SuaYoo you can test the return values to see if it's in a form that works for us. Current format of response, with arbitrary made-up data:

{
    "screenshotMatch": [{"lowerBoundary": "0.0", "count": 0},{"lowerBoundary": "0.7", "count": 3}, {"lowerBoundary": "0.9", "count": 5}]
    "textMatch": [{"lowerBoundary": "0.0", "count": 0}, {"lowerBoundary": "0.7", "count": 1}, {"lowerBoundary": "0.9", "count": 2}, {"lowerBoundary": "0.95", "count": 5}]
}

Takes an arbitrary set of thresholds for text and screenshot matches
as a comma-separated list of floats.

Returns a list of groupings for each that include the lower boundary
and count for all sets that have matching data.
@tw4l tw4l requested review from ikreymer and SuaYoo April 16, 2024 20:27
@ikreymer
Copy link
Member

I think the output format makes sense, but i think there should always be an entry with {"lowerBoundary": "0.0", right?

@tw4l
Copy link
Member Author

tw4l commented Apr 17, 2024

I think the output format makes sense, but i think there should always be an entry with {"lowerBoundary": "0.0", right?

Good call! Updated to manually add any missing thresholds and the implicit 0.0 threshold to the results even when count is 0 within that bucket.

@ikreymer
Copy link
Member

Looks good! (And we can figure out what to do for resources in a separate PR)

@tw4l tw4l merged commit 30ab139 into main Apr 17, 2024
3 of 4 checks passed
@tw4l tw4l deleted the issue-1659-qa-run-aggregate-stats branch April 17, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QA: Add endpoint for aggregated QA run stats
2 participants