-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change resource table to be based on mime type #1698
Conversation
Converted to draft because there's an issue where if a category exists for replay but not crawl, it throws an uncaught TypeError |
|
Switched to iterating through |
- if resourceType is script, stylesheet, image, font, use that definitely - if resourceType is fetch/xhr, also check for extension, specifically for images - also check for extension for json - also check for pdf by type + extension - categorize 'ping' as 'other' - use first part of mime as fallback
Added a few more improvements, incorporating the resourceType as follows:
|
…properties of each resource
Follow-up to #1689
Instead of using resource types, let's use the first half of mime types now, with a few manual substitutions to ensure that favicons, javascript, html, and stylesheets are put into better categories than just e.g.
text
.