Frontend QA: show currently sorted heuristic percentages in page list #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
reviewed
Apr 22, 2024
| export const textColorFromSeverity = cached((severity: Severity) => { | ||
| switch (severity) { | ||
| case "good": | ||
| return tw`text-green-600`; |
There was a problem hiding this comment.
Ah I haven't thought of using tw in utilities in this way, cool!
There was a problem hiding this comment.
Yeah, it's handy! In this case we don't actually really need it, cause we're definitely using all these classes elsewhere already, but if we weren't this would ensure that the compiler knows to include them.
SuaYoo
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1690
Swaps out the "+n" number for a percentage when sorting by percentage values