Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QA run deletion #1721

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Fix QA run deletion #1721

merged 2 commits into from
Apr 22, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Apr 22, 2024

Related: #1477

Changes

Fixes unable to delete QA run from the QA tab "Analysis Runs" list.

Manual testing

  1. Log in as crawler
  2. Go to Archived Item with analysis runs
  3. Click "Analysis Runs"
  4. Open run action menu and "Delete Analysis Run"
  5. Confirm deletion. Verify item is removed from list

@SuaYoo SuaYoo requested review from emma-sg and tw4l April 22, 2024 19:52
emma-sg
emma-sg approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Tested and working 👍

@SuaYoo SuaYoo merged commit db6091b into main Apr 22, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-fix-qa-run-delete branch April 22, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuaYoo @emma-sg