Add QA page analysis chart #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to move thresholds to tooltip per @emma-sg and @Shrinks99 feedback: 
|
|
Some updated screenshots
|
emma-sg
approved these changes
Apr 23, 2024
|
Happy with this at this point! |
tw4l
reviewed
Apr 23, 2024
tw4l
reviewed
Apr 23, 2024
|
Nice work! |
tw4l
approved these changes
Apr 23, 2024
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
SuaYoo
commented
Apr 23, 2024
| () => | ||
| html`<sl-tooltip | ||
| content=${qaRun.state.startsWith("stop") | ||
| ? msg("This analysis run was stopped and is not complete.") |
There was a problem hiding this comment.
Nitpick, but this would include stopping, which isn't yet stopped. Maybe we should explicitly list stopped states in utils/crawler, by activeCrawlStates, to keep it all in one place?
There was a problem hiding this comment.
Oh, I suppose that's true, but don't we only show finished qa runs here to select from? https://github.com/webrecorder/browsertrix/blob/main/frontend/src/pages/org/archived-item-detail/ui/qa.ts#L482-L484
SuaYoo
commented
Apr 23, 2024
| import { pluralize } from "./localization"; | ||
|
|
||
| // Add to this as necessary! | ||
| const plurals = { |
SuaYoo
commented
Apr 23, 2024
| return stats; | ||
| }, | ||
| args: () => | ||
| [this.orgId!, this.crawlId!, this.qaRunId, this.authState] as const, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1589
Changes
Note, I deviated from the wireframes to remove the "QA Analysis" heading since we only have one card now. It also feels like "Page Match Analysis" is a more precise heading for this particular chart. Open to alternatives.
Manual testing
Screenshots
Follow-ups
We'll probably want to refactor
btrix-meterafter conversation toTailwindComponentto simplify reusability.