Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll archived items list #1730

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Poll archived items list #1730

merged 5 commits into from
Apr 23, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Apr 23, 2024

Resolves #1477, fixes unreported bug

Changes

  • Refreshes archived items page every 5 seconds to get in progress QA runs.
  • Refactors archived items to use TailwindComponent and lit tasks
  • Adds back all columns to upload list to prevent layout shift (see follow-ups)
  • Fixes list not updating after search value is selected.

Manual testing

  1. Log in as any role
  2. Go to "Archived Items"
  3. Go to an archived item with a lot of pages and start a QA run
  4. Go back to "Archived Items". Verify that QA run progress indicator updates every 5 seconds.
  5. Regression test search, sort, filter, and pagination controls.

Follow-ups

  • This is an initial task implementation, further cleanup can be handled in [Feature]: Refactor API calls to use @lit/task #1716.
  • We might want a minor redesign of the archived item list to handle non-applicable information (like QA columns in uploads) more elegantly, instead of removing columns altogether--this was causing a layout shift when switching between item types in the archived item list.

@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l April 23, 2024 17:59
<div class="my-12 flex w-full items-center justify-center text-2xl">
<sl-spinner></sl-spinner>
</div>
`,
)}
pending: () =>
// TODO differentiate between pending between poll and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emma-sg any ideas for a quick solve here? otherwise I'll track it in #1716

@tw4l
Copy link
Member

tw4l commented Apr 23, 2024

Working well in testing!

@SuaYoo SuaYoo merged commit 1f4440d into main Apr 23, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-poll-archived-items branch April 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: QA Review UI v1
3 participants