Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update links to running crawls #2378

Merged
merged 4 commits into from
Feb 12, 2025
Merged

fix: Update links to running crawls #2378

merged 4 commits into from
Feb 12, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Feb 10, 2025 •
edited
Loading

Resolves #2376

Changes

  • Updates links to running crawls to redirect to workflow "Watch" tab
  • Removes unused "Jump to crawl" superadmin widgets
  • Refactors archived item component to remove references to active crawls

Manual testing

  1. Log in as superadmin
  2. Start a crawl
  3. Click "Running Crawls"
  4. Click a crawl. Verify you're redirected to the workflow "watch" view
  5. Click "Crawls" tab. Verify you're unable to click the currently running crawl in the list

Screenshots

Page Image/video
Superadmin dashboard Screenshot 2025-02-10 at 3 45 18 PM

tw4l
tw4l approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is a big improvement ❤️

@Shrinks99 Shrinks99 mentioned this pull request Feb 11, 2025
Merged
Shrinks99
Shrinks99 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Happy to see this one resolved!

@SuaYoo SuaYoo force-pushed the frontend-fix-running-crawl-links branch from fa9ce62 to f6b3239 Compare February 12, 2025 00:48
@SuaYoo SuaYoo merged commit 7ce1155 into main Feb 12, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-fix-running-crawl-links branch February 12, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@tw4l tw4l tw4l approved these changes

@CamilleLaw1 CamilleLaw1 Awaiting requested review from CamilleLaw1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archived items are shown as running
4 participants
@SuaYoo @ikreymer @Shrinks99 @tw4l