Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small api fixes #1962

Merged
merged 7 commits into from
Oct 23, 2018
Merged

Small api fixes #1962

merged 7 commits into from
Oct 23, 2018

Conversation

bentiss
Copy link
Contributor

@bentiss bentiss commented Oct 23, 2018

A small batch of updates to provide a few fixes for the REST API:

  • also export the cards created with an older wekan instance (without linked cards) (related to JSON export #1873)
  • fix the GET customFields API that was failing
  • allow to directly overwrite the members of cards and boards with a PUT call (this avoids to do multiple calls to add and remove users)
  • allow to change the swimlane of a card from the API

Note: I signed an Apache like CLA and directly sent to @xet7, as my employer didn't want me to sign the current wekan CLA


This change is Reviewable

This allows to see the progress of the generation of the
Docker image.
6eeb708 (Fix cards export and add customFields export.) is
incomplete as it allows to export newer cards inserted in the db after
the linkedId has been set, but not older cards present in an earlier
version of wekan.

Allow both null and empty value to be retrieved to match all cards.

related wekan#1873
All of the other REST API are in the form 'modelId' but a few ones in
boards.js and users.js.

Change it for a more uniform API.
Calling GET on /api/board/XXXX/customfields
returns a 500 error:

 TypeError: Converting circular structure to JSON
Allows to change the members from the API
Allows to change the members from the API.
@xet7
Copy link
Member

xet7 commented Oct 23, 2018

@bentiss

For changes to REST API, please document it to wiki directly to some related or new page:
https://github.com/wekan/wekan/wiki/REST-API-Role

@xet7 xet7 merged commit dfdba25 into wekan:edge Oct 23, 2018
xet7 added a commit that referenced this pull request Oct 23, 2018
- Also export the cards created with an older wekan instance (without linked cards) (related to #1873);
- Fix the GET customFields API that was failing;
- Allow to directly overwrite the members of cards and boards with a PUT call (this avoids to do multiple calls to add and remove users);
- Allow to change the swimlane of a card from the API.

Thanks to bentiss !
@bentiss bentiss deleted the api-fixes branch October 24, 2018 07:38
@bentiss
Copy link
Contributor Author

bentiss commented Oct 24, 2018

For changes to REST API, please document it to wiki directly to some related or new page:
https://github.com/wekan/wekan/wiki/REST-API-Role

I just sent a PR to automatically generate the docs: #1965. If you don't like it, I can always copy/paste the markdown in the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants