Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: remove no-op data-x-for attributes #11125

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Editorial: remove no-op data-x-for attributes #11125

merged 1 commit into from
Mar 12, 2025

Conversation

foolip
Copy link
Member

@foolip foolip commented Mar 12, 2025

Wattsi doesn't use this attribute, it has no effect.

data-x="concept-document-url" and data-x="concept-document-origin" are
already used to link to these definitions, no for="" needed.


/dom.html ( diff )

Wattsi doesn't use this attribute, it has no effect.

data-x="concept-document-url" and data-x="concept-document-origin" are
already used to link to these definitions, no for="" needed.
@foolip
Copy link
Member Author

foolip commented Mar 12, 2025

This originated in #1187 and was copied in #6249. I found this while working on whatwg/html-build#296.

@foolip foolip requested a review from annevk March 12, 2025 10:37
@domenic domenic merged commit 09ec343 into main Mar 12, 2025
2 checks passed
@domenic domenic deleted the data-x-for branch March 12, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants