allow the user to select a version of the library to load #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +53,7 @@ def to_js(element_id) | |||
| # Parameters: | |||
| # *div_id [Required] The ID of the DIV element that the Google Chart should be rendered in. | |||
| def load_js(element_id) | |||
| "\n google.load('visualization','1', {packages: ['#{package_name}'], callback: #{chart_function_name(element_id)}});" | |||
| "\n google.load('visualization', '#{version}', {packages: ['#{package_name}'], callback: #{chart_function_name(element_id)}});" | |||
There was a problem hiding this comment.
Line is too long. [134/80]
|
Thanks for the PR. Can you fix the build (ignore the HoundCI messages)? Once it's fixed, I can merge it. Thank you! |
|
Rebased with master and merged manully as 7bffe1d. Thanks! |
JuanitoFatas
added a commit
that referenced
this pull request
May 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful if, for example, you want to load a release candidate of the chart.
Version can be provided as part of the options hash, or as a setter once the chart object has been created.