Adds ability to generate Material charts when applicable #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| def load_material_js(element_id) | ||
| "\n google.load('visualization','1.1', {packages: ['#{material_package_name.downcase}'], callback: #{chart_function_name(element_id)}});" |
There was a problem hiding this comment.
Line is too long. [144/80]
Uses Material options instead of core chart options argument
| @listeners.each do |listener| | ||
| js << "\n google.visualization.events.addListener(chart, '#{listener[:event]}', #{listener[:callback]});" | ||
| end | ||
| js << "\n chart.draw(data_table, google.charts.#{material_package_name}.convertOptions(#{js_parameters(@options)}));" |
There was a problem hiding this comment.
Line is too long. [126/80]
Merged
|
👍 Awesome. Thanks for the integration @winston |
|
Welcome! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing in
material: trueto the render_chart helper, this will render the "Material" style google graphs.https://google-developers.appspot.com/chart/interactive/docs/gallery/scatterchart#Material
Example usage:
<%= render_chart(@chart, 'scatterchart_material', {material: true}) %>Not all graphs are Material enabled so it will be up to the developer to determine if this option can be used.