Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Behaviour default views #1312

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open

Behaviour default views #1312

wants to merge 28 commits into from

Conversation

jaxwilko
Copy link
Member

@jaxwilko jaxwilko commented Feb 17, 2025 •
edited by LukeTowers
Loading

This PR adds support for using default views for the FormController & ListController behaviour. Included is a patch that changes the create:controller command to not generate these files unless --stubs is passed.

To Review:

@jaxwilko jaxwilko requested a review from LukeTowers February 17, 2025 10:51
@mjauvin
Copy link
Member

mjauvin commented Feb 17, 2025

I've been wanting to do this for ages...

Great work!

@LukeTowers @mjauvin
Update modules/backend/behaviors/listcontroller/_list_toolbar.php
8b65ce0 
Co-authored-by: Marc Jauvin <marc.jauvin@gmail.com>
@LukeTowers LukeTowers added the enhancement PRs that implement a new feature or substantial change label Feb 17, 2025
@LukeTowers LukeTowers added this to the 1.2.8 milestone Feb 17, 2025
@jaxwilko
Copy link
Member Author

@LukeTowers @mjauvin any thoughts on my changes to ViewMaker?

@mjauvin
Copy link
Member

mjauvin commented Feb 17, 2025

@LukeTowers @mjauvin any thoughts on my changes to ViewMaker?

I like it @jaxwilko, as long as it doesn't introduce BC issues, which it shouldn't.

@LukeTowers LukeTowers mentioned this pull request Feb 26, 2025
Closed
@LukeTowers LukeTowers mentioned this pull request Feb 27, 2025
Draft
@mjauvin
Copy link
Member

mjauvin commented Feb 27, 2025

This is such a great improvement, will make renaming a controller much less tedious!

@mjauvin
Copy link
Member

mjauvin commented Mar 3, 2025

Running this on all controllers for my latest project in dev, so far so good!

@mjauvin
Copy link
Member

mjauvin commented Mar 4, 2025

@LukeTowers anything preventing this to be merged?

@LukeTowers
Copy link
Member

@mjauvin I need to finish going through the rest of the Winter plugins and testing it out to make sure we're not missing any pieces. Already had some valuable changes just from implementing it on the Blog plugin so I want to check the remaining ones. Will be working on it again tomorrow during office hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjauvin mjauvin mjauvin left review comments

@LukeTowers LukeTowers LukeTowers left review comments

Assignees
No one assigned
Labels
enhancement PRs that implement a new feature or substantial change
Projects
None yet
Milestone
1.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@jaxwilko @mjauvin @LukeTowers