Allow "winter:util compile" command to download Font Awesome if required #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennothommo
added
the
maintenance
|
@bennothommo can we change the packages that are requiring that file to be compiled with mix or vite instead of adding this complexity for the old asset compilation system? |
|
@LukeTowers we already use Mix to compile the icons normally. This is just a workaround for people who can't use Mix/Vite to still be able to compile assets the old way if they need. It was to basically circumvent this issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience, or if a user is unable to use NPM and/or
php artisan mix:install, this will allow thephp artisan winter:util compile lesscommand to download Font Awesome if it does not exist, and place the necessary files in location in order to allow LESS compilation to work.