Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strong typing for events emitted by login targets #4

Merged
merged 2 commits into from
Mar 18, 2023
Merged

Add strong typing for events emitted by login targets #4

merged 2 commits into from
Mar 18, 2023

Conversation

smithki
Copy link
Collaborator

@smithki smithki commented Mar 18, 2023

Also moves the event emitter methods to .events as opposed to inheritance.

@smithki smithki added enhancement New feature or request minor Increment the minor version when merged labels Mar 18, 2023
@smithki smithki merged commit 1af1ae5 into main Mar 18, 2023
@smithki smithki deleted the smithki/strongly-typed-events branch March 18, 2023 00:25
@smithki
Copy link
Collaborator Author

smithki commented Mar 18, 2023

🚀 PR was released in v0.2.0 🚀

@smithki smithki added the released This issue/pull request has been released. label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@smithki