Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swayfx compat changes #84

Merged
merged 9 commits into from
Jan 4, 2025
Merged

swayfx compat changes #84

merged 9 commits into from
Jan 4, 2025

Conversation

WillPower3309
Copy link
Member

This PR contains changes to scenefx related to the swayfx rebase (WillPower3309/swayfx#367)

@WillPower3309 WillPower3309 marked this pull request as draft December 7, 2024 01:47
@WillPower3309
Copy link
Member Author

This has some good commits for mainline. Going to merge and can open new PRs for any other needed work

@WillPower3309 WillPower3309 marked this pull request as ready for review January 4, 2025 22:24
@WillPower3309
Copy link
Member Author

Ill let @ErikReider give an approval first though in case he thinks this needs anything else

Copy link
Member

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I don't really have any reference about the gradient logic but those changes don't look out of place :)

@WillPower3309 WillPower3309 merged commit ae7bacc into main Jan 4, 2025
@WillPower3309 WillPower3309 deleted the swayfx-compat branch January 4, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants