Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update centre-id.csv #117

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Update centre-id.csv #117

merged 3 commits into from
Mar 14, 2024

Conversation

antje-s
Copy link
Contributor

@antje-s antje-s commented Mar 14, 2024

adding new centre-id for Global Cache function

adding new centre-id for Global Cache function
Copy link
Contributor

@josusky josusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking the quotes are needed only if a field contains coma, but as a general rule we could use quotes everywhere as a safety measure, especially if the file is edited in a plain text editor.

de-dwd-gts-to-wis2,"Deutscher Wetterdienst, GTS to WIS2 Gateway"
de-dwd-global-cache,"Deutscher Wetterdienst, WIS2 Global Cache"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other centre-id's who are global services in this list, suggest to update to:

de-dwd-global-cache,"Deutscher Wetterdienst, Global Cache Service"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tomkralidis tomkralidis merged commit 55af9a8 into main Mar 14, 2024
1 check passed
@tomkralidis tomkralidis deleted the de-dwd_adding_centre-id4gc branch March 14, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants