Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename resource-type.csv to notification-type.csv (#54) #56

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update and rename resource-type.csv to notification-type.csv (#54) #56

merged 1 commit into from
Sep 26, 2023

Conversation

tomkralidis
Copy link
Collaborator

Fixes #54

@tomkralidis tomkralidis mentioned this pull request Sep 25, 2023
Closed
josusky
josusky approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@josusky josusky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It caught my eye that you meticulously updated values in the "child" column. We can probably drop that one as we know which CSV corresponds to which level in WTH. But that is independent issue, of course.

@tomkralidis tomkralidis merged commit e89a7f1 into main Sep 26, 2023
@tomkralidis tomkralidis deleted the issue-54 branch September 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josusky josusky josusky approved these changes

@gaubert gaubert Awaiting requested review from gaubert

@amilan17 amilan17 Awaiting requested review from amilan17

@solson-nws solson-nws Awaiting requested review from solson-nws

@davidpodeur davidpodeur Awaiting requested review from davidpodeur

@jsieland jsieland Awaiting requested review from jsieland

@antje-s antje-s Awaiting requested review from antje-s

@Amienshxq Amienshxq Awaiting requested review from Amienshxq

@McDonald-Ian McDonald-Ian Awaiting requested review from McDonald-Ian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename resource-type.csv
2 participants
@tomkralidis @josusky