Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VersionStream for rust-1.85 #43406

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Adding VersionStream for rust-1.85 #43406

merged 4 commits into from
Feb 26, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Feb 22, 2025

No description provided.

Signed-off-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
Copy link
Contributor Author

octo-sts bot commented Feb 22, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error message and context, I'll provide a detailed analysis and solution:

• Detected Error: "unknown field parallel-compiler, expected one of [...] for key rust"

• Error Category: Configuration

• Failure Point: Configuration parsing of config.toml during the bootstrap process

• Root Cause Analysis:
The --set="rust.parallel-compiler=false" configuration option is no longer supported in Rust 1.85.0. This option was removed from the rust compiler configuration.

• Suggested Fix:
Remove the following line from the configure options:

--set="rust.parallel-compiler=false"

• Explanation:
The parallel-compiler option was deprecated and removed in recent Rust versions. The error occurs because the configuration system no longer recognizes this setting. Removing it will allow the build to proceed with default parallel compilation settings.

• Additional Notes:

  1. The current configuration includes other valid rust-specific settings like codegen-units and musl-root
  2. The parallel compilation is now handled automatically by the build system
  3. Build performance can still be controlled through the --jobs parameter

• References:

To implement the fix, modify the ./configure command in the pipeline section by removing the --set="rust.parallel-compiler=false" line. The rest of the configuration can remain unchanged as it is valid for Rust 1.85.0.

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Feb 22, 2025
parallel compiler option was removed here 
rust-lang/rust@eedafbc

Signed-off-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Feb 22, 2025
…lvm version

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws debasishbsws self-assigned this Feb 26, 2025
@debasishbsws debasishbsws requested a review from a team February 26, 2025 14:14
@debasishbsws debasishbsws enabled auto-merge (squash) February 26, 2025 14:14
@debasishbsws debasishbsws merged commit bd70f61 into main Feb 26, 2025
22 checks passed
@debasishbsws debasishbsws deleted the rust-1.85 branch February 26, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. service:version-stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants