This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Convert product-elements/price to TypeScript #7534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
type: enhancement
nielslange
requested review from
wavvves and
imanish003
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
16 tasks
|
Size Change: +7 B (0%) Total Size: 999 kB
ℹ️ View Unchanged
|
imanish003
approved these changes
Nov 2, 2022
imanish003
reviewed
Nov 2, 2022
Co-authored-by: Manish Menaria <the.manish.menaria@gmail.com>
TypeScript Errors ReportFiles with errors: 447
assets/js/atomic/blocks/product-elements/price/block.tsx
assets/js/atomic/blocks/product-elements/price/edit.tsx assets/js/atomic/blocks/product-elements/price/index.ts assets/js/blocks/cart/cart-cross-sells-product-list/cart-cross-sells-product.tsx |
TypeScript Errors ReportFiles with errors: 447
assets/js/atomic/blocks/product-elements/price/block.tsx
assets/js/atomic/blocks/product-elements/price/edit.tsx assets/js/atomic/blocks/product-elements/price/index.ts assets/js/blocks/cart/cart-cross-sells-product-list/cart-cross-sells-product.tsx |
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
…hub.com:woocommerce/woocommerce-blocks into update/7092-convert-product-element-price-to-TS # Conflicts: # assets/js/atomic/blocks/product-elements/price/edit.tsx
TypeScript Errors ReportFiles with errors: 447
assets/js/atomic/blocks/product-elements/price/block.tsx
assets/js/atomic/blocks/product-elements/price/edit.tsx assets/js/atomic/blocks/product-elements/price/index.ts assets/js/blocks/cart/cart-cross-sells-product-list/cart-cross-sells-product.tsx |
Thanks for your review, @imanish003. I addressed all your feedback. Would you mind doing another review? |
TypeScript Errors ReportFiles with errors: 445
assets/js/atomic/blocks/product-elements/price/block.tsx
assets/js/atomic/blocks/product-elements/price/edit.tsx assets/js/atomic/blocks/product-elements/price/index.ts assets/js/blocks/cart/cart-cross-sells-product-list/cart-cross-sells-product.tsx |
wavvves
approved these changes
Nov 8, 2022
nielslange
deleted the
update/7092-convert-product-element-price-to-TS
branch
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7092
Currently, the
product-elements/priceis still written in JS and is using prop-types for type checking. This PR aims to convertproduct-elements/priceto TypeScript.Testing
User Facing Testing
Single Product blockto it.Product Price inner blockis still visible.