This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Product Query: Add order by “Top rated” as a preset #7715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunyatasattva
added
type: enhancement
rubikuserbot
requested review from
a team and
nefeline
and removed request for
a team
TypeScript Errors ReportFiles with errors: 427 🎉 🎉 This PR does not introduce new TS errors. |
|
The release ZIP for this PR is accessible via: |
|
Size Change: +17 B (0%) Total Size: 971 kB
ℹ️ View Unchanged
|
sunyatasattva
force-pushed
the
add/7324-add-orderby-best-selling-to-product-query
branch
from
7cda22f to
13a0331
Compare
Base automatically changed from
add/7324-add-orderby-best-selling-to-product-query
to
trunk
November 21, 2022 18:22
nefeline
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Great work 🎉 ! The feature works as expected: left a few suggestions in the code and a question regarding the tests.
Test Results
Add a Product Query block. Change “Newest” to “Top rated” on the Popular Filters dropdown..
✅ Confirmed the "Top rated" option exists
Ensure the new order is based on the average rating.
✅ Confirmed it works as expected.
✅ When the product ratings are updated, the block displays the correct updated order based on the new average rating.
Ensure steps 4 and 6 work on the front-end.
Do you mind clarifying what steps 4 and 6 are?
🤦♀️ sorry. I edited the PR description. I just meant check that the order is preserved on the front-end. |
sunyatasattva
force-pushed
the
add/7326-add-orderby-rating-to-product-query
branch
from
f1da26d to
5a3db96
Compare
sunyatasattva
deleted the
add/7326-add-orderby-rating-to-product-query
branch
tarunvijwani
pushed a commit
that referenced
this pull request
Nov 24, 2022
* Add safety guard to `extend_rest_query_allowed_params`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the second preset: “Top rated products”. By selecting this, users can sort products by their average rating.
This builds on the previously added REST API filter to enable further allowed sort orders.
Fixes #7326
Accessibility
Testing
User Facing Testing
WooCommerce Visibility
Changelog