Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Cart Block > Ensure no console errors are displayed when an invalid coupon is applied #7969

Closed
wants to merge 4 commits into from
Closed

Cart Block > Ensure no console errors are displayed when an invalid coupon is applied #7969

wants to merge 4 commits into from

Conversation

nefeline
Copy link
Contributor

Fixes #7485

With this change, no errors should be displayed on the console after attempting to apply an invalid coupon code.

Screenshots

Before After
Screenshot 2022-12-16 at 14 43 16 Screenshot 2022-12-16 at 14 41 17

User Facing Testing

  1. Add the Cart Block to a post/page and access it
  2. Apply a non-existent coupon
  3. Open the JS console on dev-tools and confirm no errors are listed.

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

Changelog

Cart Block: Fixed the console error displayed when an invalid coupon was added to the cart.

@woocommercebot woocommercebot requested review from a team and sunyatasattva and removed request for a team December 16, 2022 13:51
@nefeline nefeline added the block: cart Issues related to the cart block. label Dec 16, 2022
@github-actions
Copy link
Contributor

The release ZIP for this PR is accessible via:

https://wcblocks.wpcomstaging.com/wp-content/uploads/woocommerce-gutenberg-products-block-7969.zip

@nefeline nefeline changed the title Ensure no console errors are displayed when an invalid coupon is applied to the Cart Block. Cart Block > Ensure no console errors are displayed when an invalid coupon is applied Dec 16, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022 •
edited
Loading

TypeScript Errors Report

Files with errors: 432
Total errors: 2102

⚠️ ⚠️ This PR introduces new TS errors on 1 files:

assets/js/base/context/hooks/cart/use-store-cart-coupons.ts

@github-actions
Copy link
Contributor

Size Change: +7.87 kB (+1%)

Total Size: 1.01 MB

Filename Size Change
build/active-filters-frontend.js 7.75 kB -2 B (0%)
build/active-filters-wrapper-frontend.js 6.01 kB -2 B (0%)
build/active-filters.js 7.32 kB -2 B (0%)
build/all-products-frontend.js 11.3 kB -1 B (0%)
build/all-products.js 33.3 kB +3 B (0%)
build/all-reviews.js 7.78 kB +2 B (0%)
build/attribute-filter-frontend.js 22.6 kB +6 B (0%)
build/attribute-filter-wrapper-frontend.js 7.66 kB +2 B (0%)
build/attribute-filter.js 12.3 kB -2 B (0%)
build/cart-blocks/cart-accepted-payment-methods-frontend.js 1.38 kB -7 B (-1%)
build/cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 5.48 kB +2 B (0%)
build/cart-blocks/cart-cross-sells-products-frontend.js 4.77 kB -1 B (0%)
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment-frontend.js 4.1 kB -944 B (-19%) 👏
build/cart-blocks/cart-express-payment-frontend.js 777 B -2 B (0%)
build/cart-blocks/cart-line-items--mini-cart-contents-block/products-table-frontend.js 5.29 kB +1 B (0%)
build/cart-blocks/cart-order-summary-frontend.js 1.23 kB -4 B (0%)
build/cart-blocks/cart-totals-frontend.js 321 B +1 B (0%)
build/cart-blocks/filled-cart-frontend.js 783 B +2 B (0%)
build/cart-blocks/order-summary-coupon-form-frontend.js 301 B -1.43 kB (-83%) 🏆
build/cart-blocks/order-summary-discount-frontend.js 483 B -1.68 kB (-78%) 🏆
build/cart-blocks/order-summary-shipping-frontend.js 5.99 kB -7 B (0%)
build/cart-blocks/order-summary-taxes-frontend.js 432 B +1 B (0%)
build/cart-blocks/proceed-to-checkout-frontend.js 1.23 kB +1 B (0%)
build/cart-frontend.js 46.3 kB +105 B (0%)
build/cart.js 46.3 kB +281 B (+1%)
build/checkout-blocks/actions-frontend.js 1.8 kB -2 B (0%)
build/checkout-blocks/billing-address--checkout-blocks/shipping-address-frontend.js 3.9 kB +2 B (0%)
build/checkout-blocks/contact-information-frontend.js 1.83 kB -1 B (0%)
build/checkout-blocks/express-payment-frontend.js 1.13 kB -1 B (0%)
build/checkout-blocks/order-note-frontend.js 1.14 kB +2 B (0%)
build/checkout-blocks/order-summary-cart-items-frontend.js 3.67 kB -1 B (0%)
build/checkout-blocks/order-summary-coupon-form-frontend.js 584 B -1.3 kB (-69%) 🏆
build/checkout-blocks/order-summary-discount-frontend.js 707 B -1.57 kB (-69%) 🏆
build/checkout-blocks/order-summary-fee-frontend.js 277 B +1 B (0%)
build/checkout-blocks/order-summary-frontend.js 1.23 kB -2 B (0%)
build/checkout-blocks/order-summary-shipping-frontend.js 6.04 kB -7 B (0%)
build/checkout-blocks/order-summary-taxes-frontend.js 431 B -1 B (0%)
build/checkout-blocks/payment-frontend.js 3.74 kB -4.57 kB (-55%) 🏆
build/checkout-blocks/shipping-methods-frontend.js 5.01 kB -2 B (0%)
build/checkout-blocks/terms-frontend.js 1.56 kB -5 B (0%)
build/checkout-blocks/totals-frontend.js 323 B -1 B (0%)
build/checkout-frontend.js 48.4 kB +141 B (0%)
build/checkout.js 40.6 kB +268 B (+1%)
build/featured-category.js 13.2 kB +4 B (0%)
build/featured-product.js 13.5 kB +4 B (0%)
build/filter-wrapper-frontend.js 13.8 kB +3 B (0%)
build/filter-wrapper.js 2.4 kB +1 B (0%)
build/handpicked-products.js 7.33 kB -2 B (0%)
build/legacy-template.js 2.86 kB +1 B (0%)
build/mini-cart-component-frontend.js 20 kB -11 B (0%)
build/mini-cart-contents-block/footer-frontend.js 2.98 kB -2 B (0%)
build/mini-cart-contents-block/products-table-frontend.js 589 B -1 B (0%)
build/mini-cart-contents.js 17.3 kB +2 B (0%)
build/mini-cart.js 4.28 kB -1 B (0%)
build/price-filter-wrapper-frontend.js 7 kB -1 B (0%)
build/price-filter.js 8.37 kB -2 B (0%)
build/product-add-to-cart-frontend.js 1.46 kB +1 B (0%)
build/product-add-to-cart.js 8.36 kB -1 B (0%)
build/product-categories.js 2.36 kB -3 B (0%)
build/product-category-list-frontend.js 1.14 kB -1 B (0%)
build/product-category.js 8.69 kB -3 B (0%)
build/product-image-frontend.js 2.17 kB -2 B (0%)
build/product-new.js 7.69 kB -1 B (0%)
build/product-on-sale.js 8.02 kB +1 B (0%)
build/product-price-frontend.js 2.17 kB +3 B (0%)
build/product-price.js 1.54 kB -2 B (0%)
build/product-rating-frontend.js 1.48 kB -3 B (0%)
build/product-sale-badge-frontend.js 1.39 kB -1 B (0%)
build/product-sale-badge.js 812 B -1 B (0%)
build/product-sku-frontend.js 629 B +1 B (0%)
build/product-stock-indicator-frontend.js 1.27 kB -1 B (0%)
build/product-summary-frontend.js 1.53 kB -2 B (0%)
build/product-summary.js 920 B +1 B (0%)
build/product-tag-list-frontend.js 1.14 kB -3 B (0%)
build/product-tag-list.js 498 B +1 B (0%)
build/product-title-frontend.js 1.59 kB +2 B (0%)
build/product-title.js 3.3 kB +2 B (0%)
build/products-by-attribute.js 8.62 kB +2 B (0%)
build/rating-filter-frontend.js 21.1 kB -1 B (0%)
build/rating-filter.js 7.39 kB +3 B (0%)
build/reviews-by-category.js 11.3 kB -2 B (0%)
build/reviews-by-product.js 12.4 kB +4 B (0%)
build/single-product-frontend.js 17.5 kB -3 B (0%)
build/single-product.js 10.1 kB +1 B (0%)
build/stock-filter-frontend.js 20.8 kB +1 B (0%)
build/stock-filter-wrapper-frontend.js 5.85 kB -1 B (0%)
build/stock-filter.js 8.13 kB -1 B (0%)
build/vendors--attribute-filter-wrapper--rating-filter-wrapper--stock-filter-wrapper-frontend.js 7.69 kB +1 B (0%)
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/order-summary-shipping--checkout-blocks--18f9376a-frontend.js 19.1 kB +2 B (0%)
build/vendors--cart-blocks/cart-cross-sells-products--product-add-to-cart-frontend.js 7.53 kB -4 B (0%)
build/vendors--cart-blocks/cart-line-items--checkout-blocks/order-summary-cart-items--mini-cart-contents---233ab542-frontend.js 3.14 kB +1 B (0%)
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/billing-address--checkout-blocks/order--5b8feb0b-frontend.js 4.82 kB -2 B (0%)
build/vendors--cart-blocks/order-summary-shipping--checkout-blocks/order-summary-shipping--checkout-block--dda5866c-frontend.js 8.85 kB -1 B (0%)
build/wc-blocks-vendors.js 64.8 kB +2.17 kB (+3%)
build/wc-blocks.js 2.63 kB +1 B (0%)
build/cart-blocks/cart-express-payment--checkout-blocks/express-payment--checkout-blocks/payment-frontend.js 4.01 kB +4.01 kB (new file) 🆕
build/cart-blocks/order-summary-coupon-form--checkout-blocks/order-summary-coupon-form-frontend.js 4.12 kB +4.12 kB (new file) 🆕
build/cart-blocks/order-summary-discount--checkout-blocks/order-summary-discount-frontend.js 4.39 kB +4.39 kB (new file) 🆕
build/vendors--checkout-blocks/payment-frontend.js 3.92 kB +3.92 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
build/blocks-checkout.js 27.2 kB
build/cart-blocks/cart-cross-sells-frontend.js 253 B
build/cart-blocks/cart-items-frontend.js 298 B
build/cart-blocks/cart-line-items-frontend.js 1.06 kB
build/cart-blocks/empty-cart-frontend.js 346 B
build/cart-blocks/order-summary-fee-frontend.js 274 B
build/cart-blocks/order-summary-heading-frontend.js 455 B
build/cart-blocks/order-summary-subtotal-frontend.js 275 B
build/checkout-blocks/billing-address-frontend.js 1.09 kB
build/checkout-blocks/fields-frontend.js 344 B
build/checkout-blocks/order-summary-subtotal-frontend.js 274 B
build/checkout-blocks/shipping-address-frontend.js 1.07 kB
build/general-style-rtl.css 1.29 kB
build/general-style.css 1.29 kB
build/mini-cart-contents-block/empty-cart-frontend.js 366 B
build/mini-cart-contents-block/filled-cart-frontend.js 230 B
build/mini-cart-contents-block/items-frontend.js 237 B
build/mini-cart-contents-block/shopping-button-frontend.js 312 B
build/mini-cart-contents-block/title-frontend.js 366 B
build/mini-cart-frontend.js 1.88 kB
build/price-filter-frontend.js 13.6 kB
build/price-format.js 1.19 kB
build/product-add-to-cart--product-button--product-category-list--product-image--product-price--product-r--a0326d00.js 225 B
build/product-add-to-cart--product-button--product-image--product-rating--product-title.js 151 B
build/product-best-sellers.js 7.71 kB
build/product-button--product-category-list--product-image--product-price--product-rating--product-sale-b--e17c7c01.js 440 B
build/product-button--product-image--product-rating--product-sale-badge--product-title.js 300 B
build/product-button-frontend.js 2.18 kB
build/product-button.js 3.85 kB
build/product-category-list.js 503 B
build/product-image.js 3.93 kB
build/product-query.js 5.95 kB
build/product-rating.js 814 B
build/product-search.js 2.62 kB
build/product-sku.js 376 B
build/product-stock-indicator.js 646 B
build/product-tag.js 8.05 kB
build/product-top-rated.js 7.93 kB
build/rating-filter-wrapper-frontend.js 6.19 kB
build/reviews-frontend.js 7.01 kB
build/vendors--attribute-filter-wrapper--mini-cart-contents-block/footer--product-add-to-cart--rating-fil--b8470171-frontend.js 6.85 kB
build/vendors--cart-blocks/cart-cross-sells-products--cart-blocks/cart-line-items--cart-blocks/cart-order--671ca56f-frontend.js 5.26 kB
build/wc-blocks-data.js 18.8 kB
build/wc-blocks-editor-style-rtl.css 5.22 kB
build/wc-blocks-editor-style.css 5.23 kB
build/wc-blocks-google-analytics.js 1.56 kB
build/wc-blocks-middleware.js 934 B
build/wc-blocks-registry.js 2.92 kB
build/wc-blocks-shared-context.js 1.52 kB
build/wc-blocks-shared-hocs.js 1.72 kB
build/wc-blocks-style-rtl.css 24.4 kB
build/wc-blocks-style.css 24.4 kB
build/wc-blocks-vendors-style-rtl.css 1.95 kB
build/wc-blocks-vendors-style.css 1.95 kB
build/wc-payment-method-bacs.js 816 B
build/wc-payment-method-cheque.js 811 B
build/wc-payment-method-cod.js 909 B
build/wc-payment-method-paypal.js 837 B
build/wc-settings.js 2.6 kB

compressed-size-action

sunyatasattva
sunyatasattva approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@sunyatasattva sunyatasattva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😁

@github-actions github-actions bot added this to the 9.2.0 milestone Dec 19, 2022
@alexflorisca alexflorisca modified the milestones: 9.2.0, 9.3.0 Dec 19, 2022
@nefeline
Copy link
Contributor Author

Going ahead and closing this PR out as it is not necessary anymore with the recent merge of: https://github.com/woocommerce/woocommerce-blocks/pull/7938/files#diff-bb82624ccdfcb948ebedc4f013344657d7538adf45c1552726dd0b1c1fbf46e2R48

@nefeline nefeline closed this Dec 19, 2022
@nefeline nefeline mentioned this pull request Dec 28, 2022
Closed
@gigitux gigitux mentioned this pull request Jan 20, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sunyatasattva sunyatasattva sunyatasattva approved these changes

Assignees
No one assigned
Labels
block: cart Issues related to the cart block.
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

JS console error displayed when attempting to apply an invalid coupon.
3 participants
@nefeline @sunyatasattva @alexflorisca