This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Refactor View Switcher to use Block Attributes #8006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejolley
added
status: needs review
block: cart
woocommercebot
requested review from
a team and
opr
and removed request for
a team
|
The release ZIP for this PR is accessible via: |
TypeScript Errors ReportFiles with errors: 438
assets/js/base/context/hooks/cart/use-store-cart.ts
assets/js/blocks/cart-checkout-shared/view-switcher/index.tsx assets/js/blocks/cart-checkout-shared/view-switcher/switcher.tsx assets/js/blocks/cart/edit.js assets/js/blocks/checkout/edit.tsx assets/js/blocks/mini-cart/mini-cart-contents/edit.tsx assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/filled-mini-cart-contents-block/edit.tsx |
|
Size Change: +1.43 kB (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/base/context/hooks/cart/use-store-cart.ts
assets/js/blocks/cart-checkout-shared/view-switcher/switcher.tsx assets/js/blocks/cart/edit.js assets/js/blocks/checkout/edit.tsx assets/js/blocks/mini-cart/mini-cart-contents/edit.tsx assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/filled-mini-cart-contents-block/edit.tsx |
opr
approved these changes
Dec 21, 2022
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Note this also removes `save` which does not exist in Gutenberg.
|
e2e fails caused by this change should now be resolved. The remaining fails seem unrelated and are being investigated by the fse team. |
imanish003
added
the
type: task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally we implemented the cart view switcher using Context, with the hope being we could get a change made in Gutenberg so that the Inner Blocks would also show the view switcher with minimal effort (WordPress/gutenberg#35078). This, however, has not been merged, so this is an alternative solution.
The proposed system in this PR removes the state/context and instead uses Block Attributes. Attributes can be accessed and updated by any block in the hierarchy using the Block Client IDs, so we can work our way up the hierarchy looking for
editorViews, and, if found, render the switcher. The switcher is rendered via a filter/hook, so it applies to all children.Fixes #6985
Testing
User Facing Testing
After testing the cart block, repeat the above tests for the mini cart block. With a block-based theme go here:
WooCommerce Visibility
Changelog