This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Context for aria-label on cart quantity controls #8099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
opr
and removed request for
a team
wavvves
added
focus: accessibility
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: +106 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
opr
approved these changes
Jan 6, 2023
assets/js/blocks/cart/cart-line-items-table/cart-line-item-row.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
Co-authored-by: Thomas Roberts <5656702+opr@users.noreply.github.com>
Thanks @opr! Committed the suggestions and I'm going to merge it after tests re-run 👍🏼 |
wavvves
deleted the
add/7492_context_for_aria_label_on_cart_quantity_controls
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “Remove item” action in the Cart block currently has no aria-label value; using Voice Over, it reads out only as the text it has. This is a bit generic without context. A user might not be sure what item is being removed from the cart. The same goes for quantity controls.
Partially Fixes #7492
Accessibility
Other Checks
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog