This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Disable compatibility layer via hook #8550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigitux
added
type: bug
gigitux
force-pushed
the
fix/8505-disable-compatibility-layer
branch
from
cc2a72d to
6f26647
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
gigitux
added
the
status: blocker
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
Aljullu
approved these changes
Feb 27, 2023
src/BlockTemplatesController.php
Outdated
| @@ -5,6 +5,7 @@ | |||
| use Automattic\WooCommerce\Blocks\Templates\BlockTemplatesCompatibility; | |||
| use Automattic\WooCommerce\Blocks\Templates\ProductAttributeTemplate; | |||
| use Automattic\WooCommerce\Blocks\Utils\BlockTemplateUtils; | |||
| use Automattic\WooCommerce\Blocks\Templates\ProductSearchResultsTemplate; | |||
There was a problem hiding this comment.
Is this class used somewhere in this file? If not, do we need to use it?
Co-authored-by: Albert Juhé Lluveras <contact@albertjuhe.com>
Thanks for the suggestions! I addressed your feedback! I will merge it 🚀 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new filter called
woocommerce_disable_compatibility_layerthat allows disabling the compatibility layer.At the same time, using the filter, the compatibility layer is disabled when Archive Product templates and Single Product template have the WooCommerce Product Grid Block.
Fixes #8505
Testing
User Facing Testing
Archive Templates
Appearance » Editor.WooCommerce Product Grid Blockis visible.WooCommerce Visibility
Changelog