Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg mobile release v1.7.0 #10026

Merged
merged 5 commits into from
Jun 14, 2019
Merged

Gutenberg mobile release v1.7.0 #10026

merged 5 commits into from
Jun 14, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 11, 2019

This PR updates the gutenberg-mobile reference to point to the latest release, v1.7.0.

The reference is currently pointing to the release/1.7.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#1116.

To test:
The block editor should work as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added this to the 12.7 milestone Jun 11, 2019
@hypest hypest requested a review from daniloercoli June 11, 2019 09:13
@hypest hypest added the Releases Label related to managing releases label Jun 11, 2019
@mkevins
Copy link
Contributor

mkevins commented Jun 11, 2019

I've tested this out on Android emulator (Pixel 2, Android 8.1.0) by adding and interacting with all the available block types. Everything seems to be working as expected for the most part.

I tested pressing [Enter] in the title, and that works as expect. I tested pasting in the title, and that does not crash 🎉 .

A few issues I did notice:

On lists, after merging two list items, then subsequently splitting them, the second list item is missing the bullet. I believe I've seen this before, and it may be a known issue, but I'm noting it so it in case it's not.

On video blocks, I have not been able to see the video after uploading one. Instead, I only see a black rectangle. In preview mode, I see:

Also, I get some logcat entries like this:

2019-06-11 21:49:14.243 6226-7177/org.wordpress.android E/WordPress-MEDIA: The passed video path is invalid: https://storeadmintestsite123.blog/vid_20190529_162012-1-mp4/
2019-06-11 21:49:14.244 6226-7177/org.wordpress.android W/WordPress-MEDIA: Failed to retrieve frame from the passed video path: https://storeadmintestsite123.blog/vid_20190529_162012-1-mp4/
2019-06-11 21:49:14.346 6226-6226/org.wordpress.android V/WordPress-MEDIA: Fetched media list for site with size: 3

Lastly, I confirmed that the caret position is not correct after pasting into an empty paragraph block, as reported here: wordpress-mobile/WordPress-iOS#11885 (review).

@daniloercoli
Copy link
Contributor

I've tested this PR on my S9 and didn't find new problems with the GB block editor.

I see issues with Videos files, but those problems are also present in the Media library of the app, where the device fails to load them. So it's not a problem related to the Editor component.

@daniloercoli daniloercoli self-requested a review June 14, 2019 09:25
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested it again with latest hash for the GB-mobile side, and worked as expected.

@mkevins
Copy link
Contributor

mkevins commented Jun 14, 2019

I've done some more smoke testing on this release, and so far, things are looking very nice. 🎉

Some additional (minor) issues I've encountered:

Image caption alignment:
It seems that the image caption center alignment gets lost when the post is updated. The caption becomes left aligned after any of the following:

  • Leave the post and open it again
  • Click update
  • View preview and then switch back to visual mode

Small images are left aligned:
This may not be an issue, but since the caption is center aligned, I'd expect that images would be center aligned as well.

Headings look like paragraph font in preview:
When previewing, I noticed that all three heading types (H2, H3, H4) appear with the same font styles as plain text paragraph content (i.e. no larger or stronger typeface).

@hypest
Copy link
Contributor Author

hypest commented Jun 14, 2019

Image caption alignment:

I think it's the same issue reported with wordpress-mobile/gutenberg-mobile#1070

Small images are left aligned

Reported in wordpress-mobile/gutenberg-mobile#830

Headings look like paragraph font in preview

Known WPAndroid issue, not related to the block editor #9916

@hypest hypest merged commit dbbc0ad into develop Jun 14, 2019
@hypest hypest deleted the gb/release-1.7.0 branch June 14, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Releases Label related to managing releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants