-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg mobile release v1.7.0 #10026
Conversation
I've tested this out on Android emulator (Pixel 2, Android 8.1.0) by adding and interacting with all the available block types. Everything seems to be working as expected for the most part. I tested pressing [Enter] in the title, and that works as expect. I tested pasting in the title, and that does not crash 🎉 . A few issues I did notice: On lists, after merging two list items, then subsequently splitting them, the second list item is missing the bullet. I believe I've seen this before, and it may be a known issue, but I'm noting it so it in case it's not. On video blocks, I have not been able to see the video after uploading one. Instead, I only see a black rectangle. In preview mode, I see: Also, I get some logcat entries like this:
Lastly, I confirmed that the caret position is not correct after pasting into an empty paragraph block, as reported here: wordpress-mobile/WordPress-iOS#11885 (review). |
I've tested this PR on my S9 and didn't find new problems with the GB block editor. I see issues with Videos files, but those problems are also present in the Media library of the app, where the device fails to load them. So it's not a problem related to the Editor component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested it again with latest hash for the GB-mobile side, and worked as expected.
- Video block is not available as expected
- Reported a non-blocker issue about span out of bounds here: RichText/AztecWrapper crashes with "set span (x+1..x+1) ends beyond length x" gutenberg-mobile#1131
I've done some more smoke testing on this release, and so far, things are looking very nice. 🎉 Some additional (minor) issues I've encountered: Image caption alignment:
Small images are left aligned: Headings look like paragraph font in preview: |
I think it's the same issue reported with wordpress-mobile/gutenberg-mobile#1070
Reported in wordpress-mobile/gutenberg-mobile#830
Known WPAndroid issue, not related to the block editor #9916 |
This PR updates the gutenberg-mobile reference to point to the latest release, v1.7.0.
The reference is currently pointing to the release/1.7.0 branch on https://github.com/wordpress-mobile/gutenberg-mobile. Relevant PR: wordpress-mobile/gutenberg-mobile#1116.
To test:
The block editor should work as normal.
Update release notes:
RELEASE-NOTES.txt
.