Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "support multiple prop in gutenberg editor" #10558

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Revert "support multiple prop in gutenberg editor" #10558

merged 1 commit into from
Oct 3, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Oct 2, 2019 •
edited
Loading

This reverts changes done by #10556 since we are in a code freeze on gutenberg mobile and this wasn't supposed to get merged during it.

I used git diff 4540c6b7c59818d85de3ee59bb45ac68dd076220 569e1b2962589b207903bf60d593038d8760da88 to compare this branch with the previous commit in develop to make sure this is reverting everything.

This reverts commit b93cf48, reversing
changes made to 569e1b2.

Fixes #

To test:

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pinarol
Revert "Merge pull request #10556 from wordpress-mobile/callstack/mul…
4540c6b 
…tiple-select"

This reverts commit b93cf48, reversing
changes made to 569e1b2.
@pinarol pinarol requested a review from marecar3 October 2, 2019 14:46
@pinarol pinarol self-assigned this Oct 2, 2019
@peril-wordpress-mobile
Copy link

You can test the changes on this Pull Request by downloading the APK here.

mkevins
mkevins approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I verified using git diff as well. 👍

@mkevins mkevins merged commit 5c2fa2e into develop Oct 3, 2019
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@mkevins mkevins deleted the issue/revert-multiple-media-pr branch October 3, 2019 07:19
etoledom added a commit that referenced this pull request Oct 3, 2019
@etoledom
Revert "Merge pull request #10558 from wordpress-mobile/issue/revert-…
d0c9da3 
…multiple-media-pr"

This reverts commit 5c2fa2e, reversing
changes made to d944b59.
@etoledom etoledom mentioned this pull request Oct 3, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@pinarol pinarol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @mkevins