Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade to React Native 0.73 #22588

Merged
merged 11 commits into from
Mar 6, 2024
Merged

build: Upgrade to React Native 0.73 #22588

merged 11 commits into from
Mar 6, 2024

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Feb 9, 2024 •
edited
Loading

Related

Description

Incorporate changes from the Gutenberg project to upgrade the React Native dependency to version 0.73.

To test: See WordPress/gutenberg#58475.

Regression Notes

  1. Potential unintended areas of impact
    Most anything in the editor view.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing outlined in build: Upgrade to React Native 0.73 WordPress/gutenberg#58475.
  3. What automated tests I added (or what prevented me from doing so)
    None, this does not add new functionality.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@dcalhoun
fix: Workaround React Native appending $PWD to the path we provide it
19cf087 
This same workaround is applied elsewhere in this file. With the latest
React Native 0.73 upgrade, the workaround is now needed in additional
locations.
@dcalhoun
build: Update react-native-reanimated to 3.6.2
74ca278 
Required for compatibility with React Native 0.73.
@dcalhoun
build: Update Gutenberg ref
66c600d
@dcalhoun dcalhoun added [Type] Task Gutenberg Editing and display of Gutenberg blocks. Tooling Build, Release, and Validation Tools labels Feb 9, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 9, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22588-7132216
Version24.4
Bundle IDorg.wordpress.alpha
Commit7132216
App Center BuildWPiOS - One-Offs #9083
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 9, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22588-7132216
Version24.4
Bundle IDcom.jetpack.alpha
Commit7132216
App Center Buildjetpack-installable-builds #8126
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@dcalhoun dcalhoun mentioned this pull request Feb 9, 2024
Merged
@dcalhoun dcalhoun changed the title build: Update to React Native 0.73 build: Upgrade to React Native 0.73 Feb 9, 2024
@dcalhoun dcalhoun mentioned this pull request Feb 10, 2024
Merged
@dcalhoun dcalhoun self-assigned this Feb 10, 2024
@dcalhoun dcalhoun marked this pull request as ready for review February 16, 2024 00:06
@dcalhoun dcalhoun requested a review from geriux February 16, 2024 00:06
@dcalhoun dcalhoun added this to the 24.4 milestone Feb 16, 2024
geriux
geriux approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 once we start the merging process, let's add an internal note in the release notes about the upgrade.

dcalhoun
dcalhoun commented Feb 23, 2024
View reviewed changes
Copy link
Member Author

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes LGTM. 🚀

@dcalhoun dcalhoun modified the milestones: 24.4, 24.5 Feb 29, 2024
@dcalhoun dcalhoun merged commit 5629703 into trunk Mar 6, 2024
24 checks passed
@dcalhoun dcalhoun deleted the build/upgrade-to-react-native-0.73 branch March 6, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriux geriux geriux approved these changes

Assignees

@dcalhoun dcalhoun

Labels
Gutenberg Editing and display of Gutenberg blocks. Tooling Build, Release, and Validation Tools [Type] Task
Projects
None yet
Milestone
24.5
Development

Successfully merging this pull request may close these issues.
3 participants
@dcalhoun @wpmobilebot @geriux