Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Plans code #24168

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Remove unused Plans code #24168

merged 2 commits into from
Mar 7, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Mar 7, 2025

It's been disabled for 5 years, and AFAIK there is no intention for implementing it natively.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Mar 7, 2025
@kean kean added this to the 25.9 milestone Mar 7, 2025
@kean kean requested review from mokagio and jkmassel March 7, 2025 20:12
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr24168-1e2526a
Version25.8
Bundle IDorg.wordpress.alpha
Commit1e2526a
App Center BuildWPiOS - One-Offs #11608
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr24168-1e2526a
Version25.8
Bundle IDcom.jetpack.alpha
Commit1e2526a
App Center Buildjetpack-installable-builds #10639
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean added this pull request to the merge queue Mar 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2025
@kean kean added this pull request to the merge queue Mar 7, 2025
Merged via the queue into trunk with commit f43f3e9 Mar 7, 2025
27 checks passed
@kean kean deleted the task/remove-unused-plans-screens branch March 7, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants