Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image alignment controls #1460

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Add image alignment controls #1460

merged 2 commits into from
Oct 28, 2019

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Oct 17, 2019 •
edited
Loading

Fixes #198 . Further details and testing instructions are in the related gutenberg PR.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@mchowning mchowning added this to the 1.16 milestone Oct 17, 2019
@mchowning mchowning mentioned this pull request Oct 25, 2019
Merged
5 tasks
@mchowning mchowning force-pushed the issue/198-image_alignment branch from 7843a8c to fb2b1a0 Compare October 25, 2019 13:01
marecar3
marecar3 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mchowning!
LGTM!

@mchowning mchowning force-pushed the issue/198-image_alignment branch from fb2b1a0 to c6eb8f6 Compare October 25, 2019 15:35
@mchowning mchowning force-pushed the issue/198-image_alignment branch from c6eb8f6 to be74409 Compare October 28, 2019 15:59
@mchowning mchowning merged commit efde2da into develop Oct 28, 2019
@mchowning mchowning deleted the issue/198-image_alignment branch October 28, 2019 18:51
@rachelmcr rachelmcr mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marecar3 marecar3 marecar3 approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16
Development

Successfully merging this pull request may close these issues.

Basic image alignment options
2 participants
@mchowning @marecar3