Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-Android #8828 fix - Just upgrade Aztec version #1475

Closed

Conversation

daniloercoli
Copy link
Contributor

This PR does only update the Aztec version used in gb-mobile to be in par with the version used in WP-Android in this PR wordpress-mobile/WordPress-Android#10620

To test:
Testing steps in the parent PR.

Update release notes:

  • [ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

…rg-mobile into issue/wp-android-8828-Aztec-crash-Android-8

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (24 commits)
  Feat: cover cross platform RangeControl (#1342)
  Introduce grouping in the block settings inspector (#1397)
  Fix native test of image block (#1456)
  Update RELEASE notes with iOS11 and Swift 5 update
  Expose WordPressUtils for consumption by gutenberg-bridge
  Update Aztec-Android ref to v1.3.33
  Update bundles
  revert missing toggle editor mode call (#1444)
  Update Aztec-iOS ref to 1.11.0
  Update Aztec-Android ref to v1.3.32
  Update Aztec-iOS ref
  Update bundles
  Bump version to 1.15.0
  Update Gutenberg
  Add Media & Text block to initial HTML
  Update Gutenberg
  Updated bundles
  Update Gutenberg
  Update Gutenberg
  Update gutenberg
  ...

# Conflicts:
#	react-native-aztec/android/build.gradle
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering, should we make a version like v1.3.34? Or does the platform 9 team do that when they do the release?

@hypest
Copy link
Contributor

hypest commented Oct 22, 2019

Wondering, should we make a version like v1.3.34? Or does the platform 9 team do that when they do the release?

Yes, please cut an Aztec version to use after wordpress-mobile/AztecEditor-Android#861 gets merged.

Also @daniloercoli, please do a block editor "hotfix" release instead of targeting develop here, so the only thing brought in the main WP app will be the the Aztec update.

@daniloercoli
Copy link
Contributor Author

Closing in favor of #1477

@daniloercoli daniloercoli deleted the issue/wp-android-8828-Aztec-crash-Android-8 branch October 28, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants