Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Specify exact TypeScript version #6

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Conversation

guarani
Copy link

@guarani guarani commented Aug 31, 2021

Description

The TypeScript dependency was not pinned to a specific version which allowed it to fetch changes that brought in breaking changes to downstream clients of this library.

Test plan

  • Test this change against Gutenberg and ensure it passes

Copy link

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul! Tested this by running npm install in the repo and the bob build step was successful.
Also the ./node_modules/.bin/tsc --version returned Version 4.1.2

@guarani guarani closed this Aug 31, 2021
@guarani guarani force-pushed the fix/typescript-version branch from be4ba53 to 5282a8f Compare August 31, 2021 15:47
A specific version avoids newer versions of TypeScript from being fetched in.
@guarani guarani reopened this Aug 31, 2021
@guarani guarani requested a review from ceyhun August 31, 2021 15:52
Copy link

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@guarani
Copy link
Author

guarani commented Aug 31, 2021

Note: The latest commit on this branch, 0b284c3, has been tagged 1.10.1-wp-2. We'll later merge this into the wp-fork branch and update Gutenberg to use it (along with the Gradle changes which are also in wp-fork).

@mchowning mchowning merged commit f1ae186 into wp-fork Aug 31, 2021
@mchowning mchowning deleted the fix/typescript-version branch August 31, 2021 17:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants