Ensure wp user update Returns Non-Zero Exit Code for Invalid Users #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wp-cli/wp-cli#5960
This PR fixes the issue where
wp user update
incorrectly exits with 0 when the provided user ID is invalid. Now, when an invalid user ID, email, or login is supplied, the command will return an exit code of 1 instead of 0, ensuring proper error handling.Testing Instructions
Try updating a non-existent user:
wp user update 9999 --user_pass=securepassword
Expected output:
Warning: Invalid user ID, email or login: '9999'
Expected exit code: 1
echo $?
Should return 1
Try updating a existent user:
wp user update 1 --user_pass=securepassword
Expected output:
Success: Updated user 1.
Expected exit code: 0
echo $?
Should return 0
Screenshot