Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SrvBroker] Init/Deinit data to avoid resilient stored data #1785

Open
wants to merge 2 commits into
base: Piers
Choose a base branch
from

Conversation

CastagnaIT
Copy link
Collaborator

Description

Since it does not know when the system cleans the data in memory, the data stored by the singleton will remain persistent each time the add-on is used despite its instance is terminated by kodi core, so force clean components pointers

Motivation and context

another attempt to fix #1770

How has this been tested?

  1. play any widevine stream
  2. play any unencrypted stream
  3. debug srvbroker vars and check the drm configuration, that must be empty

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • I have read the Contributing document
  • My code follows the Code Guidelines of this project
  • My change requires a change to the Wiki documentation
  • I have updated the documentation accordingly

@CastagnaIT CastagnaIT added Type: Fix non-breaking change which fixes an issue v22 Piers labels Feb 26, 2025
@CastagnaIT
Copy link
Collaborator Author

@lrusak last time you give me some hints
do you have time to take a look? should i make the data not persistently stay in memory in the singleton
could be good this solution? or are there more elegant solutions?

Since it does not know when the system cleans the data in memory, the
data stored by the singleton will remain persistent each time the add-on
is used, so force clean components pointers
@CastagnaIT CastagnaIT force-pushed the srvbroker_data_mem branch from 95a0e29 to 49be36a Compare March 5, 2025 13:43
the class deconstructor dont works with singleton's
so its needed an appropriate reset function
otherwise same state of the component is kept on next instance of the addon
@CastagnaIT CastagnaIT force-pushed the srvbroker_data_mem branch from 49be36a to 8a52729 Compare March 6, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Fix non-breaking change which fixes an issue v22 Piers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [v22.1.12] ISA uses a different unwrapper_params value than expected
1 participant