-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Typeable constraint to a few LayoutClass instances #398
Conversation
Seems reasonable to me. |
7b69cc9
to
0c3dc7f
Compare
I thought some more about this and decided that it's best if we merge this as is. This PR doesn't really change or enable anything, so it doesn't make sense to add documentation and changelog entry for it. I changed the commit message to say:
So that's my plan now. Get these two preparatory changes merged and released in the right order, and then add a
If you still find my plan reasonable, I think this is now ready to be merged and xmonad/xmonad#242 can then be merged as well. |
I think it's still worth a brief note in the CHANGELOG, since in theory anyone using these instances may have things break if they don't already have a |
However, overall I think the plan sounds reasonable. |
This enables adding the Typeable constraint to LayoutClass itself (xmonad/xmonad#242) which in turn enables querying the current layout state. That might be useful to e.g. show the current X.L.WorkspaceDir in xmobar. This is a preparation commit that fixes the compile failures that would result in merging that change to xmonad. For this to be generally useful we first need to merge (and ideally also release) that xmonad change, and then we'll need some documentation and perhaps a type class to help find the right LayoutModifier in the tree of ModifiedLayouts and Choices. That will come later.
0c3dc7f
to
b989655
Compare
You've got a point. :-) Here:
force-pushed. |
Description
This enables adding the Typeable constraint to LayoutClass itself
(xmonad/xmonad#242)
which in turn enables querying the current layout state. That might be
useful to e.g. show the current X.L.WorkspaceDir in xmobar.
Example usage: liskin/dotfiles@6ea6c52
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.md
fileI updated the
XMonad.Doc.Extending
file (if appropriate)before merging, I need to finish the above checklist tasks, but I'd like to gather feedback first