Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TA-1797] KEK-03: Insufficient Check When Adding And Removing Validator In poa Module #16

Merged
merged 9 commits into from
Jan 31, 2024
Merged

[TA-1797] KEK-03: Insufficient Check When Adding And Removing Validator In poa Module #16

merged 9 commits into from
Jan 31, 2024

Conversation

AdriaCarrera
Copy link
Contributor

@AdriaCarrera AdriaCarrera commented Jan 30, 2024 •
edited
Loading

KEK-03: Insufficient Check When Adding And Removing Validator In poa Module PR

Issues 🥇

Changes 🛠️

  • Send staking MsgCreateValidator when adding a new member in the PoA
  • Restrict unbond and redelegate staking operations by adding a new ante handler

@AdriaCarrera
Merge branch 'main' into issue/kek-03
49700f8 
# Conflicts:
#	app/app.go
@AdriaCarrera AdriaCarrera changed the title [TA-] KEK-03: Insufficient Check When Adding And Removing Validator In poa Module [TA-1797] KEK-03: Insufficient Check When Adding And Removing Validator In poa Module Jan 30, 2024
@notion-workspace Notion Workspace
Copy link

KEK-03 | Insufficient Check When Adding And Removing Validator In poa Module

AdriaCarrera
AdriaCarrera commented Jan 31, 2024
View reviewed changes
x/poa/proposal_handler.go Outdated
@@ -24,7 +24,9 @@ func NewValidatorProposalHandler(k keeper.Keeper) govtypes.Handler {
}

func handleAddValidatorProposal(ctx sdk.Context, k keeper.Keeper, p *types.AddValidatorProposal) error {
return k.ExecuteAddValidator(ctx, p.ValidatorAddress)
return nil
// TODO: What this?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this TODO

@AdriaCarrera AdriaCarrera merged commit de08674 into main Jan 31, 2024
2 of 3 checks passed
@AdriaCarrera AdriaCarrera deleted the issue/kek-03 branch January 31, 2024 18:31
@AdriaCarrera AdriaCarrera mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeersyst jpeersyst Awaiting requested review from jpeersyst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdriaCarrera