Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add tm ibc client to fix v2 upgrade #23

Merged
merged 1 commit into from
May 3, 2024
Merged

[FIX] Add tm ibc client to fix v2 upgrade #23

merged 1 commit into from
May 3, 2024

Conversation

AdriaCarrera
Copy link
Contributor

Add tm ibc client to fix v2 upgrade

Motivation 💡

Upgrade to V2 was breaking due to the lack of an IBC module

Changes 🛠

  • Add IBC tendermint light client "github.com/cosmos/ibc-go/v7/modules/light-clients/07-tendermint" in the AppModules

@AdriaCarrera AdriaCarrera requested a review from jpeersyst May 2, 2024 07:40
@pullpo-for-slack Pullpo for Slack
Copy link

🔗Pullpo.io Slack channel

jpeersyst
jpeersyst approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@jpeersyst jpeersyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No conec com ha de funcionar IBC però sembla que tot bé. Has afegit el AppModuleBasic i els altres mòduls com el Keeper ja hi eren.

@AdriaCarrera AdriaCarrera merged commit 99a18b2 into main May 3, 2024
3 checks passed
@AdriaCarrera AdriaCarrera deleted the fix/tm-abci-upgrade branch May 3, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpeersyst jpeersyst jpeersyst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdriaCarrera @jpeersyst