[TA-1796] APP-02 Potential Gas Fee Stealing and DoS Attack Due to Missing Check of Nested Messages in Authz Transaction #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Check of Nested Messages in Authz Transaction
AdriaCarrera
requested review from
AgustinMJ,
GuillemGarciaDev and
jpeersyst
AdriaCarrera
changed the title
jpeersyst
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Sembla que el codi i els canvis son els correctes i que et demanen però no em queda clara un cosa.
En el report diuen el següent:
Recommend the fix in Ethermint and Evmos to reject the following message types, MsgEthereumTx and MsgCreateVestingAccount to be the nested message in authz
Diuen que hem de posar aquest disable al ante de ethermint i hi he mirat i ja està posat. Per tant, si continua fallant (tal i com sembla pel test que han fet), si que té sentit que sigui del ante de la app.
Jo crec que està bé però m'ha semblat raro que posi Ethermint and Evmos al report.
Has fet check que el que diuen no passa amb els canvis?
|
Closing as depecrated by #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.