Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in MPI test #31

Merged
1 commit merged into from
Feb 7, 2025
Merged

Fixes in MPI test #31

1 commit merged into from
Feb 7, 2025

Conversation

szymonlopaciuk
Copy link
Contributor

Description

Needs xsuite/xfields#161. Xfields version 0.22.0 caused the MPI tests of Xwakes to start failing. The two PRs patch up the problem. In the future, a better assertion or a mechanism of comparison of _ConvData should be invented.

Checklist

Mandatory:

  • I have added tests to cover my changes
  • All the tests are passing, including my new ones
  • I described my changes in this PR description

Optional:

  • The code I wrote follows good style practices (see PEP 8 and PEP 20).
  • I have updated the docs in relation to my changes, if applicable
  • I have tested also GPU contexts

@szymonlopaciuk szymonlopaciuk closed this pull request by merging all changes into xsuite:main in 75e38ff Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant