Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linting): Add Taskfile tasks to run linters. #76

Merged
merged 39 commits into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
ba6986c
support linter in task
haiqi96 Oct 24, 2024
f0ec0b0
fix
haiqi96 Oct 24, 2024
0366aec
fix permission
haiqi96 Oct 24, 2024
66d5945
update version
haiqi96 Oct 24, 2024
6087f0d
Properly update dependency and add rules to overwrite extern indentation
haiqi96 Oct 25, 2024
c4f00f6
Apply linter to file
haiqi96 Oct 25, 2024
79ddd8c
Some other changes
haiqi96 Oct 25, 2024
d2e3ac2
Update github flow to run linter properly
haiqi96 Oct 25, 2024
eb460cd
remove deprecated dependency from workflow
haiqi96 Oct 25, 2024
9dd98ff
Fix yml based on linter recommendation
haiqi96 Oct 25, 2024
6a81eb7
Remove overkill script
haiqi96 Oct 25, 2024
b64d77e
Remove overkill script
haiqi96 Oct 25, 2024
7f1d61d
Revert G_ prefix change
haiqi96 Oct 25, 2024
151cf8f
temp
haiqi96 Oct 27, 2024
eba2157
Merge branch 'main' into move_work_around
haiqi96 Oct 28, 2024
51f8726
updates
haiqi96 Oct 28, 2024
95fd572
Let task use a list of directories instead of hardcoded ones in the l…
haiqi96 Oct 28, 2024
0a2a971
Update readme
haiqi96 Oct 28, 2024
1ddfc77
Fix reference
haiqi96 Oct 28, 2024
b0c0632
Simplify commands
haiqi96 Oct 28, 2024
75ad8f6
Add mypy and docformatter to the linter task
haiqi96 Oct 28, 2024
be7c738
Update readme
haiqi96 Oct 28, 2024
469a294
Add missing dependency
haiqi96 Oct 28, 2024
9b42c6d
Update util version
haiqi96 Nov 1, 2024
1f1ba36
Use latest clang-format and clang-tidy from yscope-dev-utils
haiqi96 Nov 1, 2024
076d02b
Merge branch 'main' into task-linter
haiqi96 Nov 19, 2024
c1da5e6
Slight customization
haiqi96 Nov 19, 2024
952be37
Slight customization
haiqi96 Nov 19, 2024
22afa5b
Revert "Slight customization"
haiqi96 Nov 19, 2024
a9f3441
Revert "Slight customization"
haiqi96 Nov 19, 2024
6604c01
Update yscope-dev-utils
haiqi96 Nov 19, 2024
cdc90da
Revert "Revert "Slight customization""
haiqi96 Nov 19, 2024
32754d6
Revert "Revert "Slight customization""
haiqi96 Nov 19, 2024
99f56bf
Apply some code review suggestions
haiqi96 Nov 22, 2024
3d37bc3
Apply more code review suggestions
haiqi96 Nov 22, 2024
b2e7e35
Update README.md
haiqi96 Nov 22, 2024
f0fd719
reorder
haiqi96 Nov 22, 2024
8189c1d
Update ruff flag
haiqi96 Nov 22, 2024
083d397
Update docs/conf/conf.py
haiqi96 Nov 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 0 additions & 164 deletions .clang-format

This file was deleted.

44 changes: 0 additions & 44 deletions .clang-tidy

This file was deleted.

5 changes: 5 additions & 0 deletions .gersemirc
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# yamllint disable-line rule:line-length
# yaml-language-server: $schema=https://raw.githubusercontent.com/BlankSpruce/gersemi/master/gersemi/configuration.schema.json

line_length: 100
list_expansion: "favour-expansion"
67 changes: 34 additions & 33 deletions .github/ISSUE_TEMPLATE/bug-report.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indentation and quote changes

Original file line number Diff line number Diff line change
@@ -1,40 +1,41 @@
name: "Bug Report"
description: Report software deficiencies
description: "Report software deficiencies"
labels: ["bug"]
body:
- type: markdown
attributes:
value: |
Use this form to report any functional or performance bugs you've found in the software.

Be sure to check if your [issue](https://github.com/y-scope/clp-ffi-py/issues) has already been reported.
- type: "markdown"
attributes:
value: |
Use this form to report any functional or performance bugs you've found in the software.

- type: textarea
attributes:
label: Bug
description: "Describe what's wrong and if applicable, what you expected instead."
validations:
required: true
Be sure to check if your [issue](https://github.com/y-scope/clp-ffi-py/issues) has already
been reported.

- type: input
attributes:
label: clp-ffi-py version
description: "The release version number or development commit hash that has the bug."
placeholder: "Version number or commit hash"
validations:
required: true
- type: "textarea"
attributes:
label: "Bug"
description: "Describe what's wrong and if applicable, what you expected instead."
validations:
required: true

- type: textarea
attributes:
label: Environment
description: "The environment in which you're using clp-ffi-py."
placeholder: "OS version, docker version, etc."
validations:
required: true
- type: "input"
attributes:
label: "clp-ffi-py version"
description: "The release version number or development commit hash that has the bug."
placeholder: "Version number or commit hash"
validations:
required: true

- type: textarea
attributes:
label: Reproduction steps
description: "List each step required to reproduce the bug."
validations:
required: true
- type: "textarea"
attributes:
label: "Environment"
description: "The environment in which you're using clp-ffi-py."
placeholder: "OS version, docker version, etc."
validations:
required: true

- type: "textarea"
attributes:
label: "Reproduction steps"
description: "List each step required to reproduce the bug."
validations:
required: true
35 changes: 17 additions & 18 deletions .github/ISSUE_TEMPLATE/feature-request.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only indentation changes

Original file line number Diff line number Diff line change
@@ -1,23 +1,22 @@
name: "Feature/Change Request"
description: Request a feature or change
description: "Request a feature or change"
labels: ["enhancement"]
body:
- type: markdown
attributes:
value: |
Use this form to request a feature/change in the software, or the project as a whole.
- type: "markdown"
attributes:
value: |
Use this form to request a feature/change in the software, or the project as a whole.

- type: textarea
attributes:
label: Request
description: "Describe your request and why it's important."
validations:
required: true

- type: textarea
attributes:
label: Possible implementation
description: "Describe any implementations you have in mind."
validations:
required: true
- type: "textarea"
attributes:
label: "Request"
description: "Describe your request and why it's important."
validations:
required: true

- type: "textarea"
attributes:
label: "Possible implementation"
description: "Describe any implementations you have in mind."
validations:
required: true
Loading
Loading